Skip to content

Add scoped component and net search to schematic viewer - #247

Merged
mohan-bee merged 22 commits into
tscircuit:mainfrom
mohan-bee:agent/add-schematic-search
Aug 19, 2026
Merged

Add scoped component and net search to schematic viewer#247
mohan-bee merged 22 commits into
tscircuit:mainfrom
mohan-bee:agent/add-schematic-search

Conversation

@mohan-bee

@mohan-bee mohan-bee commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Motivation

  • Finding components and nets across schematic sheets should work reliably on realistic boards across desktop and mobile viewers.
Screen.Recording.2026-08-20.at.12.17.57.AM.mov

https://schematic-viewer-esz5ju9r6-tscircuit.vercel.app/?fixtureId=%7B%22path%22%3A%22examples%2Fexample34-full-board-schematic-search.fixture.tsx%22%7D

@vercel

vercel Bot commented Jul 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
schematic-viewer Ready Ready Preview Aug 19, 2026 7:11pm

Request Review

@mohan-bee mohan-bee changed the title Add component and net search with cross-sheet focus Add component and net search with across sheets focus Jul 30, 2026
@mohan-bee
mohan-bee marked this pull request as ready for review July 30, 2026 15:23

@seveibar seveibar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the original version of this was an icon

@seveibar

Copy link
Copy Markdown
Contributor

also the Ctrl-F is not scoped to when the mouse is over the schematic viewer, any page this is on it would completely disable ctrl-f (AWFUL)

I mentioned BOTH of these issues on discord!!!

@mohan-bee mohan-bee changed the title Add component and net search with across sheets focus Add scoped component and net search to schematic viewer Aug 6, 2026
@mohan-bee
mohan-bee requested a review from seveibar August 6, 2026 18:07

@imrishabh18 imrishabh18 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

@imrishabh18 imrishabh18 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, Esc should collapse the search bar. It doesn't work right now

@imrishabh18 imrishabh18 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get review from Seve

@seveibar

seveibar commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

@mohan-bee mot working on mobile, cant click it!

@seveibar seveibar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a real board and not something so simple? I don't understand how you could zoom in on VCC which would have net labels everywhere

Comment thread package.json Outdated
@mohan-bee

Copy link
Copy Markdown
Contributor Author

@seveibar when in multisheet it will show them as a metadata ,, also it switched the sheet when they got the prefered search result.

@mohan-bee
mohan-bee merged commit 0c2933a into tscircuit:main Aug 19, 2026
4 checks passed
@mohan-bee
mohan-bee deleted the agent/add-schematic-search branch August 19, 2026 19:18
@tscircuitbot

Copy link
Copy Markdown

Thank you for your contribution! 🎉

PR Rating: ⭐⭐⭐
Impact: Major

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants